Merge pull request #1976 from nidhiazad/feature/ELY-2619_GHC_Nidhi_Azad

ELY-2619 : Immediately return this expression instead of assigning it to the temporary variable
wildfly-security · Sep 22, 2023 · 43808af · 43808af
2 parents 37dc8b3 + 33e2923
commit 43808af
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/http/oidc/src/main/java/org/wildfly/security/http/oidc/OidcHttpFacade.java b/http/oidc/src/main/java/org/wildfly/security/http/oidc/OidcHttpFacade.java
@@ -121,8 +121,7 @@ public Principal getPrincipal() {
                 SecurityIdentityCallback securityIdentityCallback = new SecurityIdentityCallback();
                 IdentityCredentialCallback credentialCallback = new IdentityCredentialCallback(new BearerTokenCredential(OidcPrincipal.class.cast(principal).getOidcSecurityContext().getTokenString()), true);
                 callbackHandler.handle(new Callback[]{credentialCallback, AuthenticationCompleteCallback.SUCCEEDED, securityIdentityCallback});
-                SecurityIdentity securityIdentity = securityIdentityCallback.getSecurityIdentity();
-                return securityIdentity;
+                return securityIdentityCallback.getSecurityIdentity();
            }
         } catch (UnsupportedCallbackException | IOException e) {
             throw new RuntimeException(e);