Adding Builder for Channels #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmesnil
reviewed
Feb 10, 2023
| /** | ||
| * Builder for channel class | ||
| */ | ||
| public static class Builder { |
There was a problem hiding this comment.
Is it required that this builder be public and part of the API?
Could we make it `package-protected so that we can use that internally (and in the tests) instead?
There was a problem hiding this comment.
I think the public builder would be useful for the Channel. The Channel has a lot of optional properties and using the public constructor is becoming a bit confusing.
But it's preferred not to expose that, I can make it package protected
There was a problem hiding this comment.
thanks for the explanation, LGTM
jmesnil
approved these changes
Feb 13, 2023
|
@spyrkob thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.