Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#18] Support logicalVersion in create/edit manifest mojos #19

Merged

Conversation

spyrkob
Copy link
Contributor

@spyrkob spyrkob commented Nov 1, 2024

Fixes #18

pom.xml Outdated
<itf.version>0.13.1</itf.version>
<itf.version>0.12.0</itf.version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @spyrkob , what's the ITF downgrade? Do you have any issues with 0.13.1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh no, sorry local diff seems to have gone weird, let me change that back

@spyrkob spyrkob force-pushed the Issue-18_support_logical_version branch from 9c2e5a1 to 727f611 Compare November 1, 2024 10:58
Copy link
Collaborator

@TomasHofman TomasHofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I will wait for the CI job to complete and merge.

@TomasHofman TomasHofman merged commit 53499c8 into wildfly-extras:main Nov 1, 2024
1 check passed
@spyrkob spyrkob deleted the Issue-18_support_logical_version branch November 1, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to set logicalVersion field when creating or editing manifest
2 participants