-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print more helpful message if no artifact matching the version pattern is found #738
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@parsharma this has to work for any patterns not just this specific one text. It probably needs to be detected at wildfly-channel library level and reported back in the exception.
I was looking with @parsharma , I think if we want to improve the message to give more details, we would have to essentially list details about all involved channels, so the original message:
would probably need to look like:
It could get quite verbose in the end, would have to somehow display details about all channels relevant to each missing artifact. Maybe necessarily we wouldn't need to modify the channel library to provide more info in the original exception, as we can get access to the list of channels ourselves in prospero, we know that all configured channels are used by the channel session. The effort and verbosity in the end doesn't look awful, but still it's to be considered if we should go into these details, to me it looks helpful for end user unless it gets too verbose. WDYT? |
Then also would that be like giving too much information to end user? Maybe it's useful to person assembling the channels, but too much info for the person running the installation..? Maybe print that in some verbose mode? Just ideas... |
Thanks for the analysis @TomasHofman! Keeping it in verbose mode might make sense. It should be a fairly small change to switch it between verbose and normal output, so we can see how it feels when it's implemented. I was originally thinking more along the lines of a short message like |
Issue: #657