Parameterised type #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`initPopulation` was a heavily overloaded parameter, with a variety of types corresponding to a range of possible behaviours. This commit: - Removes the option to pass a vector representing the search space. This is specific and unclear, and behaviour can easily be easily represented by one of the other options - Restricts `initPopulation` to be a vector of individuals (where an individual is a single member of the population) - Adds a new parameter `creation` to represent a function to create an individual. Default behaviour has not been changed, but is now represented by a creation function.
aahaselgrove
force-pushed
the
parameterised_type
branch
from
ee377cb
to
486e2be
Compare
aahaselgrove
force-pushed
the
parameterised_type
branch
from
486e2be
to
eea4d41
Compare
`initPopulation` was a heavily overloaded parameter, with a variety of types corresponding to a range of possible behaviours. This commit: - Removes the option to pass a vector representing the search space. This is specific and unclear, and behaviour can easily be easily represented by one of the other options - Restricts `initPopulation` to be a vector of individuals (where an individual is a single member of the population) - Adds a new parameter `creation` to represent a function to create an individual. Default behaviour has not been changed, but is now represented by a creation function.
The `getIndividual` function was performing unnecessary work, so is factored out in this commit. Instead, a sample individual is passed as a parameter. This has the added benefit of making it clear to a reader what kind of data is being worked with. Note: n-queens P increased to 200 due to flaky test. of accessing members
of accessing members
aahaselgrove
force-pushed
the
parameterised_type
branch
from
eea4d41
to
0cd421d
Compare
|
Note that I have made a number of PRs over the last couple of days, and I have been rebasing this one on top of those. I have done this because this is probably the most controversial, and hence the other PRs should be addressed first. |
|
I'm rewriting the package interface to provide more modular solution for existing and new implementations, see #49. It's very much follows the Optim.jl package design. The new API will provide ability to initialize population separately, and move the bulk of the computations into the dedicated function allowing various implementations, e.g. thread-parallel or multicore, without modifying core parts of the package. |
|
Implemented in new api, see Docs/Dev/Population |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getIndividualfunction was performing unnecessary work, so isfactored out in this commit. Instead, a sample individual is passed
as a parameter. This has the added benefit of making it clear to a
reader what kind of data is being worked with.
Note: n-queens P increased to 200 due to flaky test.