Simplify Dockerfiles #254
Merged
Simplify Dockerfiles #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to add one more commit to this using a base regression Dockerfile to eliminate code duplication Edit: Done |
montehurd
force-pushed
the
simplify-dockerfiles
branch
from
b0402e8
to
0f76799
Compare
|
@montehurd this works fine on my M1 when I tested it, are you ready to go? I think we can update our test on our GitHub actions to run on ARM (I've done it here. I can make a PR and see if it will just work :) |
Closed
|
Yes I think it's ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies Dockerfile.a11y-regression, Dockerfile.visual-regression and Dockerfile.mediawiki
Uses smaller "FROM" base images
Preserves ability to run locally on ARM macOS machines (specifying the platform as
linux/amd64explicitly keeps Rosetta happy)Faster Docker image builds on macOS as it no longer has to fetch and install Chromium .deb files
Tested on Intel arch Ubuntu box too