Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-deduplicate rule generation #59

Merged
merged 1 commit into from
Jan 23, 2019
Merged

De-deduplicate rule generation #59

merged 1 commit into from
Jan 23, 2019

Conversation

edg2s
Copy link
Member

@edg2s edg2s commented Jan 23, 2019

Creates four generators:

  • createCollectionMethodRule: $(...).method(...)
  • createCollectionPropertyRule: $(...).property
  • createUtilMethodRule: $.method(...)
  • createUtilPropertyRule: $.property

Not touched by this change are rules with more complex criteria,
and rules where the distinction hasn't been made between util
methods and collection methods e.g. $.text() and $(...).text().

Doesn't touch the tests to ensure no functionality is changed.

Part of #55

Creates four generators:
* createCollectionMethodRule: $(...).method(...)
* createCollectionPropertyRule: $(...).property
* createUtilMethodRule: $.method(...)
* createUtilPropertyRule: $.property

Not touched by this change are rules with more complex criteria,
and rules where the distinction hasn't been made between util
methods and collection methods e.g. $.text() and $(...).text().

Doesn't touch the tests to ensure no functionality is changed.

Part of #55
@jdforrester
Copy link
Member

Very nice.

@jdforrester jdforrester merged commit c6a2ce2 into master Jan 23, 2019
@jdforrester jdforrester deleted the dedupe branch January 23, 2019 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants