-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support open-zeppelin upgrades validations #358
Open
fullkomnun
wants to merge
7
commits into
wighawag:master
Choose a base branch
from
fullkomnun:support_openzeppelin_upgrades_validations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support open-zeppelin upgrades validations #358
fullkomnun
wants to merge
7
commits into
wighawag:master
from
fullkomnun:support_openzeppelin_upgrades_validations
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… new implementation and the old one
This was referenced Aug 2, 2022
why is this still not merged? I think it's very useful |
Any update on this? @wighawag |
Hey any update on that? Wold be really useful |
@wighawag I can rebase or re-create it on top of the latest 'main' branch it that helps.. |
@wighawag This is essential to upgrading contracts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #65
Fixes: #355
Builds on top of previous efforts
@openzeppelin/hardhat-upgrades
hardhat plugin as a dependency as suggested here and instead copies-over minimal amount of glue code@openzeppelin/upgrades-core
and@types/proper-lockfile
(used to lock cache file while writing validations)hardhat-deploy
APIs and deployment files as suggested hereTODO
Possible Enhancements
(Users may currently disable some checks)