fix error when calling signout method with revoketokens set to true #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraible
approved these changes
Sep 26, 2023
|
Thank you for your contribution, @xabierarima! |
|
Hi @mraible, Could you please create a new release that includes the changes from this PR? |
|
@xabierarima I don't have the ability to do a release. Only @wi3land can do a release. |
|
@mraible I gave you access to do releases last year via a GitHub action, you just need to create a new release and publish it. |
|
@wi3land I'm sorry, that slipped my mind. I'll try to do a release now. FWIW, I was laid off from Okta in February, so my interest in this space could change depending on what I do next. However, we still use this library in Ionic for JHipster and I'm interested in maintaining that functionality. |
|
v2.1.0 has been published. https://github.com/wi3land/ionic-appauth/releases/tag/v2.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch fixes this issue: #220
Calling the signOut method with revokeTokens set to true fails because revokeTokens deletes the token from the storage and then the signOut method tries to delete the same token again. My fix is to check that the token exists before deleting it.
I have also made a change to performEndSessionRequest. I don't check if _tokenSubject.value is undefined because if revokeTokens has been called before it will be undefined but we still want to call end session endpoint.