Multi org process logger #1575
Open
Multi org process logger #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naddeoa
force-pushed
the
multi-org-process-logger
branch
3 times, most recently
from
b1c1970
to
8ed8981
Compare
We need to support multi org workflows. Currently, the process rolling logger stores all of its profiles keyed off of the dataset id, assuming that the global whylabs api key applies to all of them more or less. Technically, its already possible to create custom writers which are the only things that know about the org but the logger would end up rolling data for different orgs into the same profiles if they have same org id. This change allows you to explicitly pass an org id into the logger which is used for cached profiles when logging. That in combination with a custom writer factory gets you to multi org logging.
naddeoa
force-pushed
the
multi-org-process-logger
branch
from
8ed8981
to
77081e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to support multi org workflows. Currently, the process rolling
logger stores all of its profiles keyed off of the dataset id, assuming
that the global whylabs api key applies to all of them more or less.
Technically, its already possible to create custom writers which are the
only things that know about the org but the logger would end up rolling
data for different orgs into the same profiles if they have same org id.
This change allows you to explicitly pass an org id into the logger
which is used for cached profiles when logging. That in combination with
a custom writer factory gets you to multi org logging.
This also updates some of the types for the most recent pyright version,
despite whylogs not actually depending on that yet.
This does end up having to be a breaking change unfortunately, though all
of these logger and actor types are still in the experimental namespace.