Fix Issue #726 - Adding a "folder does not have filter" #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution! 🙇 |
|
Learned about git rebase this week, so I thought it would be best for cleanliness if I combined all my commits into a single one. |
|
I'm a big fan of |
|
Ooo! I didn't know that was possible, that also seems like a very useful tool from a maintainer perspective! I'm still learning so many new things about git, thanks! |
|
Thank you @rokaicker for your PR 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I think I've got the new feature working (Issue 726). Please let me know if there are any changes to be made.
Also, would it be okay to tag this for hacktoberfest?
By the way, your code base is amazingly organized and incredibly modular, and I learned a lot just by navigating through the filter workflow.