Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding compact view option also for filmstrip view #706

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Adding compact view option also for filmstrip view #706

merged 1 commit into from
Feb 20, 2023

Conversation

semla
Copy link
Contributor

@semla semla commented Oct 11, 2021

As per issue #684

@whyboris
Copy link
Owner

Thank you @semla -- the code looks great! I'll test it out to see how it looks in the GUI and will try to merge it in soon.
It might be a few weeks as I'm a bit busy with house stuff still.
Cheers 🙌

Copy link
Owner

@whyboris whyboris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking great in the UI as well 👍

I'm happy to adjust the code myself after the merge, but please let me know if you'd like to fix a few minor things:

  • there is now a horizontal scrollbar on the bottom (for some reason I think the filmstrip is wider than the view 🤔 )
  • when compact mode is toggled, the filename is still showing up behind the filmstrip (and can be seen a bit to the left)

No worries if you'd rather not mess with it -- I'll happily merge this in and fix it myself -- later this winter when I'm back to coding on the app.

@semla
Copy link
Contributor Author

semla commented Oct 31, 2022

Glad to hear it is looking good!
Busy at the moment and it has been a while since I saw the code so I think I leave the fixes for you.
Cheers

@whyboris
Copy link
Owner

whyboris commented Nov 1, 2022

Thank you for the quick response 🤝 I'll fix up the minor edge case -- I appreciate the addition 🙇

Maybe this weekend 🤞

@whyboris
Copy link
Owner

I'm hoping to have a release at the end of February 😓 -- this year has been busier than I ever anticipated.

@whyboris
Copy link
Owner

I have a guess why there was some need for css improvement 😅 -- in the code (template) you instruct the app to use a class called compact-margins but it isn't part of the PR 👌

I'll merge in and fix in main

Thank you again for the contribution 🙇

This will be a part of the 5th Anniversary Release today 🥳

@whyboris whyboris merged commit 2fa639b into whyboris:main Feb 20, 2023
@whyboris
Copy link
Owner

🙇 thank you @semla for your contribution -- I made a small fix with this commit: 09c57b8

Looks beautiful ❤️

@semla semla deleted the compact-view-filmstrip branch February 27, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants