-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add http forwarder #29
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. A general-purpose "relay to an HTTP endpoint" dispatcher would be useful. I've added some comments and questions.
…gic away from Dispatcher, updated unit tests to include HTTP mock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the first round of updates and apologies for the delay in getting to them. It all looks good but I've flagged a few more "details".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like http.go
and http_test.go
are both still using the bespoek HTTPClient
rather than a plain-vanilla http.Client{}
instance?
@thisisaaronland any suggestions on how to modify this? |
Something like this? |
added an http forwarder dispatcher - can be configured in the config.json with http://host/test