Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add http forwarder #29

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

bradstimpson
Copy link

added an http forwarder dispatcher - can be configured in the config.json with http://host/test

Copy link
Member

@thisisaaronland thisisaaronland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. A general-purpose "relay to an HTTP endpoint" dispatcher would be useful. I've added some comments and questions.

daemon/daemon.go Outdated Show resolved Hide resolved
dispatcher/dispatcher.go Outdated Show resolved Hide resolved
dispatcher/dispatcher.go Outdated Show resolved Hide resolved
dispatcher/dispatcher.go Outdated Show resolved Hide resolved
dispatcher/http.go Outdated Show resolved Hide resolved
dispatcher/http.go Outdated Show resolved Hide resolved
dispatcher/http.go Outdated Show resolved Hide resolved
dispatcher/http.go Outdated Show resolved Hide resolved
dispatcher/http_test.go Outdated Show resolved Hide resolved
dispatcher/http.go Show resolved Hide resolved
Copy link
Member

@thisisaaronland thisisaaronland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the first round of updates and apologies for the delay in getting to them. It all looks good but I've flagged a few more "details".

dispatcher/http.go Outdated Show resolved Hide resolved
dispatcher/http.go Outdated Show resolved Hide resolved
dispatcher/http.go Outdated Show resolved Hide resolved
dispatcher/http.go Show resolved Hide resolved
Copy link
Member

@thisisaaronland thisisaaronland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like http.go and http_test.go are both still using the bespoek HTTPClient rather than a plain-vanilla http.Client{} instance?

@bradstimpson
Copy link
Author

@thisisaaronland any suggestions on how to modify this?

@thisisaaronland
Copy link
Member

Something like this?

#29 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants