Skip to content
This repository has been archived by the owner on Aug 3, 2021. It is now read-only.

FloatArray Log Messages #49

Closed
wants to merge 4 commits into from
Closed

Conversation

stephanbro
Copy link

@stephanbro stephanbro commented Nov 11, 2016

  • Use Float32MultiArray instead of GenericLogMessage to allow easier plotting (in rqt_plot for example)

Depends on bitcraze/lps-ros#7

@whoenig
Copy link
Owner

whoenig commented Nov 14, 2016

Those changes look good to me. I will need to wait for the other two dependent changes in order to merge it though (I added a comment/question in the firmware pull request regarding that change).
Thanks!
Wolfgang

@stephanbro stephanbro changed the title Thrust float FloatArray Log Messages Nov 28, 2016
@ataffanel
Copy link
Contributor

The PR bitcraze/lps-ros#7 is dependent of this. As far as I can tell it is the last dependency for this PR. As soon as this PR is merged I will be able to merge bitcraze/lps-ros#7

@whoenig
Copy link
Owner

whoenig commented Dec 8, 2016

That switch loses the time information of the header. Without the time, it will be difficult to plot data correctly (the main feature of the timestamp is that you can select the on-board timestamp, allowing to get clean plots over time for the various logging variables).
Would it help to change https://github.com/whoenig/crazyflie_ros/blob/master/crazyflie_driver/msg/GenericLogData.msg#L2 to Float32MultiArray instead for plotting?

@stephanbro
Copy link
Author

Ah that's a good point. I don't have time to work on this these days, so I'll close this PR until I get a chance to look at this again.

@stephanbro stephanbro closed this Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants