New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the scroll-(up|down)-command tests #1807

Merged

whitphx merged 2 commits into main from fix/page-move-tests

Jan 11, 2024

Owner

whitphx commented Jan 11, 2024 •

edited

Loading

cursorPageDown command's behavior has been changed in the current ver. of VSCode Web, so the test started to fail.
These test cases don't have to check the cursor movements precisely. Instead, checking the internally called command is enough.

whitphx added 2 commits

January 11, 2024 17:33


          Fix the scroll-(up|down)-command tests

94523e2


          Call sinon.restore() diffensively

bb18709

whitphx merged commit a746c1c into main

6 checks passed

whitphx deleted the fix/page-move-tests branch

January 11, 2024 08:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet