Ctrl-S doesn't seem to work at all

[dbikel]

C-s seemed to be bound initially to both the Find Next action as well as emacs-mcx.isearchForward. However, this sort of worked, in that hitting C-s would bring up the native VSCode "Find" overlay in the upper right-hand corner, but the focus would not be on it, so it would require a mouse click to enter a search string. Subsequent hitting C-s would then search for that string.

This is quite different from true emacs-style incremental search, in which one hits C-s then immediately starts typing characters, and the search string is found (or not) as typing happens, with subsequent C-s resulting in finding subsequent instances of the current search string, if any.

Is true emacs-like increment search (both forward and backward) in the works? Or is there a particular trick to enabling it? I tried removing the the C-s keybinding from "Find Next", but this resulted in nothing happening when hitting C-s.

Note that none of the above is related to the editor.find.seedSearchStringFromSelection setting (which I disabled).

[whitphx]

hitting C-s would bring up the native VSCode "Find" overlay in the upper right-hand corner, but the focus would not be on it

That's weird. It does not happen in my env (macOS, VSCode 1.67.2 (Universal)) and the find widget gets focused with the first C-s hitting.

• Please describe your environment, e.g. OS, VSCode version, or any other special configs if exist
• Please try the lower versions of this extension than v0.41.0. Since then, the implementation of C-s has been changed.
  • Ref: i-search (C-s) initialization #1278

[dbikel]

Can you please also comment on whether the default keymap assigns Ctrl-S to *both* the native Find command *and* the extensions' isearchForward command? Thanks, Dan.

…

On Fri, May 27, 2022 at 12:04 PM Yuichiro Tachibana (Tsuchiya) < ***@***.***> wrote: hitting C-s would bring up the native VSCode "Find" overlay in the upper right-hand corner, but the focus would not be on it That's weird. It does not happen in my env (macOS, VSCode 1.67.2 (Universal)) and the find widget gets focused with the first C-s hitting. - Please describe your environment, e.g. OS, VSCode version, or any other special configs if exist - Please try the lower versions of this extension than v0.41.0. Since then, the implementation of C-s has been changed. - Ref: #1278 <#1278> — Reply to this email directly, view it on GitHub <#1322 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGUYZECGXGWHWLKMKRVA6TVMDXBLANCNFSM5VVECUIQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[whitphx]

both the native Find command and the extensions' isearchForward command?

Should this "the native Find command" be "the native Find Next command"?
If so, that's normal and intended.
Grep "ctrl+s" in https://github.com/whitphx/vscode-emacs-mcx/blob/main/package.json then you can find

vscode-emacs-mcx/package.json

Lines 2436 to 2440 in b858fda

	{
	"key": "ctrl+s",
	"command": "emacs-mcx.isearchForward",
	"when": "!findInputFocussed"
	},

and

vscode-emacs-mcx/package.json

Lines 2441 to 2445 in b858fda

	{
	"key": "ctrl+s",
	"command": "editor.action.nextMatchFindAction",
	"when": "findInputFocussed"
	},

which shows that these commands are both assigned to C-s with different conditions so that the first C-s opens the find widget (emacs-mcx.isearchForward) then the subsequent C-s triggers the native Find Next command (editor.action.nextMatchFindAction).

[dbikel]

I installed v.40.1 and now it works. For reference, here are the details of my environment: Version: 1.58.2022040902 (Universal) Commit: 42ae4e6e61cc01a0f841f8b1df8f43ce8405b09e Date: 2022-04-11T16:40:18.483Z Electron: 12.0.13 Chrome: 89.0.4389.128 Node.js: 14.16.0 V8: 8.9.255.25-electron.0 OS: Darwin arm64 21.4.0

…

On Tue, May 31, 2022 at 9:59 AM Yuichiro Tachibana (Tsuchiya) < ***@***.***> wrote: *both* the native Find command *and* the extensions' isearchForward command? Should this "the native Find command" be "the native Find Next command"? If so, that's normal and intended. Grep "ctrl+s" in https://github.com/whitphx/vscode-emacs-mcx/blob/main/package.json then you can find https://github.com/whitphx/vscode-emacs-mcx/blob/b858fda3fb48cb1c1cb27a4b32599e5117f9ce5c/package.json#L2436-L2440 and https://github.com/whitphx/vscode-emacs-mcx/blob/b858fda3fb48cb1c1cb27a4b32599e5117f9ce5c/package.json#L2441-L2445 which shows that these commands are both assigned to C-s with different conditions so that the first C-s opens the find widget ( emacs-mcx.isearchForward) then the subsequent C-s triggers the native Find Next command (editor.action.nextMatchFindAction). — Reply to this email directly, view it on GitHub <#1322 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGUYZGEXE5LBFF3SOISZ2TVMYLNDANCNFSM5VVECUIQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[whitphx]

Thanks, so it's because you are using an older version of VSCode.
Please see #1279 (comment)

As the versions of this extension between v0.41.0 and v0.42.0 have invalid version compatibility metadata and cause confusion like yours, I wanted to unpublish these versions, but could not: microsoft/vsmarketplace#235

[dbikel]

Oh, that makes sense! Thanks for the update. I'll work on getting my company to provide a more recent version of VSCode. Thanks also for making this VSCode extension! I sent in a donation to show my appreciation. :)

…

--Dan.

On Wed, Jun 1, 2022 at 5:50 AM Yuichiro Tachibana (Tsuchiya) < ***@***.***> wrote: Thanks, so it's because you are using an older version of VSCode. Please see #1279 (comment) <#1279 (comment)> As the versions of this extension between v0.41.0 and v0.42.0 have invalid version compatibility metadata and cause confusion like yours, I wanted to unpublish these versions, but could not: microsoft/vsmarketplace#235 <microsoft/vsmarketplace#235> — Reply to this email directly, view it on GitHub <#1322 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGUYZG3TSEHCWQQ65KPUR3VM4W7PANCNFSM5VVECUIQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[whitphx]

👍
Thank you for your sponsorship!