Emacs text registers (#1643)

* New methods to create "register save" and "register insert" commands that play nicely with existing Rect-related commands

* New methods to create "register save" and "register insert" commands that play nicely with existing Rect-related commands

* - Changed TextRegister class to be a simple Map<string, string>
- Changed vscode.window.showInformationMessage() to MessageManager.showMessage()
- Made RegisterSaveCommand de-select the selection after saving the selection

* Removed commented region

* Per feedback - refactoring text registers to be shared across multiple document windows (multiple EmacsEmulator objects)

* - Removed extraneous not-in-vanilla-Emacs messages
- Made startRegisterSaveCommand() private
- Made textEditor.edit((editBuilder) ...) use await in saveRegister() method

keybinding-generator/cli.mts

@@ -8,6 +8,7 @@ import {
   generateKeybindings,
   generateKeybindingsForPrefixArgument,
   generateKeybindingsForTypeCharInRectMarkMode,
+  generateKeybindingsForRegisterCommands,
 } from "./generate-keybindings.mjs";
 
 const srcFilePath = "./keybindings.json";
@@ -32,6 +33,11 @@ keybindingSrcs.forEach((keybindingSrc) => {
     dstKeybindings.push(...generateKeybindingsForTypeCharInRectMarkMode());
     return;
   }
+  if (keybindingSrc.$special == "registerCommandTypes") {
+    console.log("Adding keybindings for register commands");
+    dstKeybindings.push(...generateKeybindingsForRegisterCommands());
+    return;
+  }
 
   if (!isKeyBindingSource(keybindingSrc)) {
     throw new Error(`${JSON.stringify(keybindingSrc)} is not a valid source`);

keybinding-generator/generate-keybindings.mts

@@ -296,3 +296,34 @@ export function generateKeybindingsForTypeCharInRectMarkMode(): KeyBinding[] {
 
   return keybindings;
 }
+
+export function generateKeybindingsForRegisterCommands(): KeyBinding[] {
+  const keybindings: KeyBinding[] = [];
+
+  // Ascii all printable characters excluding delete.
+  // Ref: https://www.ascii-code.com/
+  const asciiPrintableChars: string[] = [];
+  // ' ' ~ '~'
+  for (let charCode = 0x20; charCode <= 0x7e; charCode++) {
+    asciiPrintableChars.push(String.fromCharCode(charCode));
+  }
+
+  for (const char of asciiPrintableChars) {
+    keybindings.push({
+      key: char,
+      when: "emacs-mcx.acceptingRectCommand && editorTextFocus && emacs-mcx.inRegisterSaveMode",
+      command: "emacs-mcx.RegisterSaveCommand",
+      args: [char],
+    });
+  }
+
+  for (const char of asciiPrintableChars) {
+    keybindings.push({
+      key: char,
+      when: "emacs-mcx.acceptingRectCommand && editorTextFocus && emacs-mcx.inRegisterInsertMode",
+      command: "emacs-mcx.RegisterInsertCommand",
+      args: [char],
+    });
+  }
+  return keybindings;
+}

keybindings.json

@@ -745,6 +745,19 @@
       "command": "emacs-mcx.killRectangle",
       "when": "emacs-mcx.acceptingRectCommand && editorTextFocus"
     },
+    {
+      "key": "s", // ctrl+x r s
+      "command": "emacs-mcx.StartRegisterSaveCommand",
+      "when": "emacs-mcx.acceptingRectCommand && editorTextFocus"
+    },
+    {
+      "key": "i", // ctrl+x r i
+      "command": "emacs-mcx.StartRegisterInsertCommand",
+      "when": "emacs-mcx.acceptingRectCommand && editorTextFocus"
+    },
+    {
+      "$special": "registerCommandTypes"
+    },
     {
       "key": "y", // ctrl+x r y
       "command": "emacs-mcx.yankRectangle",