Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolveRefsAt does not properly handle references to the root document #88

Closed
whitlockjc opened this issue Jun 16, 2016 · 0 comments
Closed

Comments

@whitlockjc
Copy link
Owner

When you run resolveRefsAt against a document, references to the document on the first pass are not identified as circular. This is because the root document name is not retained in a way where internal documents can identify the reference is circular on the first pass.

whitlockjc added a commit that referenced this issue Apr 20, 2017
The resolver was rewritten to fix numerous bugs and performance issues.
The reason for this is over the years, bug fixes and features have been
added on top of json-refs and its resolver logic has become crufty.  The
new rewrite is clean, does not reinvent the wheel and fixes many bugs.

Fixes: #80, #87, #88, #89, #97, #101, #103
whitlockjc added a commit that referenced this issue Apr 20, 2017
The resolver was rewritten to fix numerous bugs and performance issues.
The reason for this is over the years, bug fixes and features have been
added on top of json-refs and its resolver logic has become crufty.  The
new rewrite is clean, does not reinvent the wheel and fixes many bugs.

Fixes: #80, #87, #88, #89, #97, #100, #101, #103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant