Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with [email protected] #45

Closed
tommybl opened this issue Mar 27, 2021 · 8 comments
Closed

Incompatibility with [email protected] #45

tommybl opened this issue Mar 27, 2021 · 8 comments
Labels
bug Something isn't working

Comments

@tommybl
Copy link

tommybl commented Mar 27, 2021

I recently upgraded storybook to 6.1.21 from 6.0.20, and this storybook-addon-html addon to the latest 5.0.0, I get this error:

ERROR in ./node_modules/@whitespace/storybook-addon-html/node_modules/prettier/standalone.js
Module build failed (from ./node_modules/babel-loader/lib/index.js):
Error: Couldn't find intersection at NodePath.getDeepestCommonAncestorFrom

I have babel-loader ^8.1.0.

Thanks

@BigFly3
Copy link

BigFly3 commented Apr 6, 2021

I'm using this add-on @ 2.0.1 and it's working up to @ 6.1.20.
After updating to @ 6.1.21, it stopped working.
I also tried @ 6.2.3 but it doesn't seem to work continuously.

@jeanfredrik
Copy link
Member

I’m not sure how to fix this. I’m continuing my digging into the matter, but meanwhile I’ve also reached out to the Storybook team in this issue: storybookjs/storybook#14489

I hope we can find a solution soon!

@shilman
Copy link

shilman commented Apr 6, 2021

Looks like there's a workaround here:

babel/minify#904 (comment)

Can you try overriding your babel settings to include these? You can look at Storybook's babel settings by running yarn storybook --debug-webpack and looking at the babel-loader entry in Preview. Or you can just override the babel setting in .storybook/main.js

https://storybook.js.org/docs/react/addons/writing-presets#babel

@denniscohn
Copy link

Any progress on this?
I've tried the workaround, but I'm not that technical... so I now disabled the storybook-addon-html but hoping for a solution on a shirt term.
Or if anyone can tell me, what I need to change so the storybook-addon-html will work again... that's also great!

@jeanfredrik
Copy link
Member

I’m taking another look now

@jeanfredrik
Copy link
Member

I need more info on how to reproduce this.

@tommybl Can you provide your config, i.e. package.json, .storybook/main.js and .storybook/preview.js or a complete repo?

@jeanfredrik jeanfredrik added the bug Something isn't working label Apr 23, 2021
@denniscohn
Copy link

For me, it's no longer an issue anymore.
I've deleted my node_module folder and run the update again, maybe I also did a npm install.
Somehow, it works now...

@jeanfredrik
Copy link
Member

Ok, great! I guess this is mostly caused by mismatches between versions of Babel, Webpack and other dependencies. I’ll close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants