Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report: [email protected] is incompatible with this add on #42

Closed
artmsilva opened this issue Mar 3, 2021 · 6 comments
Closed
Labels
bug Something isn't working

Comments

@artmsilva
Copy link

artmsilva commented Mar 3, 2021

I recently upgraded to [email protected]. This add on @4.2.0 is throwing this error.

Uncaught TypeError: Cannot read property 'name' of undefined

@artmsilva artmsilva changed the title Bug report: Current version of Storybook is incompatible with this add on Bug report: [email protected] is incompatible with this add on Mar 3, 2021
@jeanfredrik
Copy link
Member

I’ve tried upgrading the example app to 6.1.21 now and I also get an error, albeit a different one:

Uncaught TypeError: Cannot convert undefined or null to object

I also get this error in the terminal during startup:

[BABEL] Note: The code generator has deoptimised the styling of /.../node_modules/prettier/standalone.js as it exceeds the max of 500KB.

Reading the Storybook changelog I can see that they have made changes to the transpilation of Prettier in 6.1.21, which I guess is the cause of this, since 6.1.20 works fine.

@jeanfredrik jeanfredrik added the bug Something isn't working label Mar 9, 2021
@tommybl
Copy link

tommybl commented Mar 25, 2021

I recently upgraded to 6.1.21 from 6.0.20 and I now get this error:

ERROR in ./node_modules/@whitespace/storybook-addon-html/node_modules/prettier/standalone.js
Module build failed (from ./node_modules/babel-loader/lib/index.js):
Error: Couldn't find intersection at NodePath.getDeepestCommonAncestorFrom

@jeanfredrik
Copy link
Member

This should now be fixed in the latest major version. I’ve updated all deps and that seemed to do it for the example apps in the repo. Please report back if upgrading to ^5.0.0 doesn’t solve the problem for you.

@tommybl
Copy link

tommybl commented Mar 26, 2021

Hi @jeanfredrik,

Unfortunately I still get the same error after upgrading storybook to 6.1.21 from 6.0.20, and upgrading storybook-addon-html to 5.0.0:

ERROR in ./node_modules/@whitespace/storybook-addon-html/node_modules/prettier/standalone.js
Module build failed (from ./node_modules/babel-loader/lib/index.js):
Error: Couldn't find intersection at NodePath.getDeepestCommonAncestorFrom

I have babel-loader ^8.1.0

Thanks

@jeanfredrik
Copy link
Member

It might be a separate bug then. Would you mind opening a new issue for it?

@tommybl
Copy link

tommybl commented Mar 27, 2021

Thanks @jeanfredrik, I opened a new issue there:

#45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants