feat: add "-all" option in preview #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clrke
reviewed
Jul 9, 2024
| @@ -7,7 +7,20 @@ function _changelogsh_preview { | |||
| raw_version=$1 | |||
| fi | |||
|
|
|||
| if [ $raw_version != "Unreleased" ]; then | |||
| if [ $raw_version == "-all" ]; then | |||
There was a problem hiding this comment.
Suggested change
| if [ $raw_version == "-all" ]; then | |
| if [ $raw_version == "--all" ]; then |
single dash is normally for one letter shortcuts like -r for --recursive and -d for --daemon. double dash is more appropriate here for --all
There was a problem hiding this comment.
Thanks for the review @clrke. Awesome as always!
However, I suggest we keep "-all" like how "find" accepts options since this tool won't be a full blown cli tool and won't be having any other options soon (even short and long version of "all")
But I defer to what @xdgimf @TheoryOfNekomata might think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #20