Expose QueueEmpty and Contacts #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schmiddiii
approved these changes
Nov 11, 2024
boxdot
previously requested changes
Nov 14, 2024
gferon
force-pushed
the
expose-queue-empty
branch
from
0c9f371 to
1b14c6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the API to remove
ReceivingModein favor of being able to keep the receiving messages loop running (= websocket open) while still handling the different phases in client code. There's an example infn sendinpresage-clion how to wait for all initial messages (untilQueueEmptyarrives) and then start sending messages.This will help with implementing boxdot/gurk-rs#196
Closes #231