fix: rng state reusage #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StdRng was cloned, which created a new rng with the same state. This
means that the same random numbers were generated:
```
use rand::{Rng, SeedableRng};
use rand::rngs::StdRng;
let mut rng1 = StdRng::from_entropy();
let mut rng2 = rng1.clone();
assert_eq!(rng1.gen::<u32>(), rng2.gen::<u32>());
```
This commit replaces the `StdRng` with `ThreadRng` in all place where it
was used. It also does not store the rng in manager anymore.
The credits for finding this bugs go to hrdl
<[email protected]>.
|
Thanks! Linking whisperfish/libsignal-service-rs#342 here since this is also related (if somebody wants to look into it later). |
gferon
approved these changes
Nov 9, 2024
|
Adding a mention of 9f717c7 where the mistake was first introduced. |
boxdot
pushed a commit
to boxdot/gurk-rs
that referenced
this pull request
Nov 12, 2024
This includes the fix whisperfish/presage#292 in particular fixing the long-standing issue #234. Also adjust usage of presage::Store API which is now asynchronous. One possibly negative side-effect is that the UI looks up in the contact names cache in read-only fashion, and only the async part of gurk can populate the cache using the store. Also fix clippy warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StdRng was cloned, which created a new rng with the same state. This
means that the same random numbers were generated:
This commit replaces the
StdRngwithThreadRngin all places where itwas used. It also does not store the rng in manager anymore.
The credits for finding this bug go to @hrdl-github
[email protected].