Set timestamp for every DataMessage #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I read my logs correctly, https://github.com/signalapp/Signal-Android/blob/0891a161b2d2b5de819f98d829370a8f12e7c124/libsignal-service/src/main/java/org/whispersystems/signalservice/api/messages/EnvelopeContentValidator.kt#L195 is triggered when syncing something that looks like a preceding receipt message, which isn't quite intended, I guess. |
This imitates the behaviour of Signal-Desktop and is required to pass envelope content validation. Previous reactions would emit this field.
hrdl-github
force-pushed
the
fix-datamessage-timestamp
branch
from
b8c0a3b to
0ff13ec
Compare
hrdl-github
added a commit
to hrdl-github/presage
that referenced
this pull request
Nov 13, 2024
The previous attempt whisperfish#290 was missing nested data messages as well as group messages.
gferon
pushed a commit
that referenced
this pull request
Nov 14, 2024
The previous attempt #290 was missing nested data messages as well as group messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This imitates the behaviour of Signal-Desktop and is required to pass envelope content validation. Previous reactions would emit this field.
This is less error-prone than requiring clients to send the timestamp in data messages.
Fixes some more instances of boxdot/gurk-rs#110 and boxdot/gurk-rs#147.