Fix sending note to self as primary without secondary devices #339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There might be a better way to do this but... here's what happens:
self
which will try to callcreate_encrypted_message
but will never send any messages because we purposefully skip sending messages to ourselves (and own device) for good reasonsidentity_key
(public key) we have for the recipient, which fails because we've never established a session with ourselves (this would only happen if we have other devices).Here are two improvements:
create_encrypted_messages
return 0 messages, do nothingis_multi_device
before even attempting to craft and send aSyncMessage
to self (that was missed when doing Only send a SyncMessage when sending to self #338)