Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sync edited messages #312

Merged
merged 3 commits into from
Jul 24, 2024
Merged

feat: sync edited messages #312

merged 3 commits into from
Jul 24, 2024

Conversation

boxdot
Copy link
Contributor

@boxdot boxdot commented Jul 22, 2024

This allows to send message edits and in particular syncs them when
using multi-device.

boxdot added 2 commits July 22, 2024 20:46
This allows to send message edits and in particular syncs them when
using multi-device.
@rubdos rubdos requested a review from direc85 July 22, 2024 18:57
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.89%. Comparing base (a2e7540) to head (e8f9f8b).
Report is 93 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
- Coverage   17.12%   16.89%   -0.23%     
==========================================
  Files          38       39       +1     
  Lines        3078     3107      +29     
==========================================
- Hits          527      525       -2     
- Misses       2551     2582      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@direc85 direc85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we're allowed to send combo edit+data message, LGTM! I can't test this myself though until next week.

We're breaking the API with returning a Vec but it's better to have it this way.

libsignal-service/src/sender.rs Show resolved Hide resolved
@rubdos rubdos merged commit 86dd9da into whisperfish:main Jul 24, 2024
18 checks passed
@boxdot boxdot deleted the main branch July 24, 2024 12:34
@boxdot boxdot restored the main branch July 24, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants