Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump protobufs #303

Merged
merged 7 commits into from
Jul 9, 2024
Merged

Bump protobufs #303

merged 7 commits into from
Jul 9, 2024

Conversation

rubdos
Copy link
Member

@rubdos rubdos commented Jul 1, 2024

Update protobuf revision version

Signal Android 7.10.2
Signal Desktop 7.17.0-alpha.1

This part is potentially relevant for PNI (cc @direc85)

diff --git a/libsignal-service/protobuf/SignalService.proto b/libsignal-service/protobuf/SignalService.proto
index 2de3e6ac7..37506c78a 100644
--- a/libsignal-service/protobuf/SignalService.proto
+++ b/libsignal-service/protobuf/SignalService.proto
@@ -439,9 +439,11 @@ message Verified {
 message SyncMessage {
   message Sent {
     message UnidentifiedDeliveryStatus {
-      reserved      /*destinationE164*/ 1;
-      optional string destinationServiceId = 3;
-      optional bool   unidentified         = 2;
+      reserved        /*destinationE164*/      1;
+      optional string destinationServiceId   = 3;
+      optional bool   unidentified           = 2;
+      reserved        /*destinationPni*/       4;
+      optional bytes  destinationIdentityKey = 5;
     }

     message StoryMessageRecipient {

@rubdos rubdos requested a review from gferon July 1, 2024 13:11
@gferon
Copy link
Collaborator

gferon commented Jul 1, 2024

oopsie, looks like a bunch of fields disappeared. otherwise, LGTM 🚀

@rubdos
Copy link
Member Author

rubdos commented Jul 1, 2024

oopsie, looks like a bunch of fields disappeared. otherwise, LGTM 🚀

Yep, didn't test because I didn't expect any faliures. Was hoping too much for protobuf to be just happy dandy "nothing to see here". :D

@rubdos
Copy link
Member Author

rubdos commented Jul 1, 2024

@gferon I added some non-trivial logic here. A pair of eyes and a brain that has been covid free for more than a week would be welcome!

@rubdos rubdos closed this Jul 1, 2024
@rubdos rubdos reopened this Jul 1, 2024
@rubdos rubdos requested a review from gferon July 1, 2024 15:11
Copy link
Collaborator

@gferon gferon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rubdos rubdos requested a review from direc85 July 9, 2024 09:40
Copy link
Contributor

@direc85 direc85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I already gave this a spin with the PNI work underneath and this seems to cause no issues at least.

libsignal-service/src/models.rs Show resolved Hide resolved
@rubdos rubdos merged commit ea55a0d into main Jul 9, 2024
19 checks passed
@rubdos rubdos deleted the bump-proto- branch July 9, 2024 14:32
@rubdos rubdos restored the bump-proto- branch July 9, 2024 14:32
@rubdos rubdos deleted the bump-proto- branch July 9, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants