-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump protobufs #303
Bump protobufs #303
Conversation
oopsie, looks like a bunch of fields disappeared. otherwise, LGTM 🚀 |
Yep, didn't test because I didn't expect any faliures. Was hoping too much for protobuf to be just happy dandy "nothing to see here". :D |
@gferon I added some non-trivial logic here. A pair of eyes and a brain that has been covid free for more than a week would be welcome! |
Signal Android 7.10.2 Signal Desktop 7.17.0-alpha.1
Co-authored-by: Matti Viljanen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I already gave this a spin with the PNI work underneath and this seems to cause no issues at least.
This part is potentially relevant for PNI (cc @direc85)