Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libsignal-protocol, zkgroup and curve25519-dalek #293

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

direc85
Copy link
Contributor

@direc85 direc85 commented Mar 1, 2024

As @boxdot said in #whisperfish Matrix channel:

boxdot: We are quite some versions behind libsignal-protocol: using v0.32.0, last released 0.40.1
boxdot: WDYT about upgrading?
boxdot: It actually builds out of the box

Update libsignal-protocol and zkgroup to v0.40.1 and curve25519-dalek to signal-curve25519-4.1.1.

Updating tests was also necessary.

Tested on-device with Whisperfish and it seems to works fine for a few sent and received messages, both in a DM and in a group.

@direc85 direc85 requested a review from gferon March 1, 2024 13:43
@gferon
Copy link
Collaborator

gferon commented Mar 1, 2024

Neat, thanks! I'll test ASAP.

@gferon
Copy link
Collaborator

gferon commented Mar 1, 2024

Works fine in my tests, merging! 🚀

@gferon gferon merged commit 689a4c2 into main Mar 1, 2024
16 of 19 checks passed
@gferon gferon deleted the libsignal-0.40.0 branch March 1, 2024 13:55
@rubdos
Copy link
Member

rubdos commented Mar 1, 2024

Updating tests was also necessary.

I don't see any updated tests?

@direc85
Copy link
Contributor Author

direc85 commented Mar 1, 2024

I don't see any updated tests?

My bad. The code compiled, but push_service::tests::create_clients test failed. I fixed the pointed piece of code (configuration.rs) with updating the offending parts from the sources pointed in the comments, but didn't realize that what I fixed wasn't a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants