Expose SignalWebSocket::is_used #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schmiddiii
added a commit
to Schmiddiii/presage
that referenced
this pull request
Dec 30, 2023
When `receive_messages` is called multiple times on the same manager, this could lead to a panic "web socket request handler not in use". This fixes this. Requires <whisperfish/libsignal-service-rs#274>. Also currently dependent on my fork of lss.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
========================================
- Coverage 3.62% 3.61% -0.02%
========================================
Files 37 37
Lines 2841 2849 +8
========================================
Hits 103 103
- Misses 2738 2746 +8 ☔ View full report in Codecov by Sentry. |
direc85
approved these changes
Jan 3, 2024
Schmiddiii
added a commit
to Schmiddiii/presage
that referenced
this pull request
Jan 4, 2024
When `receive_messages` is called multiple times on the same manager, this could lead to a panic "web socket request handler not in use". This fixes this. Requires <whisperfish/libsignal-service-rs#274>. Also currently dependent on my fork of lss.
gferon
pushed a commit
to whisperfish/presage
that referenced
this pull request
Jan 4, 2024
When `receive_messages` is called multiple times on the same manager, this could lead to a panic "web socket request handler not in use". This fixes this. Requires <whisperfish/libsignal-service-rs#274>. Also currently dependent on my fork of lss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to fix a panic
web socket request handler not in usedue to reuse of the same websocket between differentreceive_messagescalls.Downstream PR: whisperfish/presage#226