Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove E164 phone numbers from ServiceAddress #198

Merged
merged 12 commits into from
Feb 8, 2023
Merged

Remove E164 phone numbers from ServiceAddress #198

merged 12 commits into from
Feb 8, 2023

Conversation

gferon
Copy link
Collaborator

@gferon gferon commented Feb 8, 2023 •
edited
Loading

TODO:

  • change types everywhere we can to not use &str since we now have a single identifier

Closes #196 #65

@gferon gferon marked this pull request as ready for review February 8, 2023 11:31
@gferon gferon requested a review from rubdos February 8, 2023 11:31
rubdos
rubdos requested changes Feb 8, 2023
View reviewed changes
Copy link
Member

@rubdos rubdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor remarks.

libsignal-service/src/cipher.rs Show resolved Hide resolved
libsignal-service/src/service_address.rs Outdated Show resolved Hide resolved
libsignal-service/src/push_service.rs Outdated Show resolved Hide resolved
libsignal-service/src/service_address.rs Outdated Show resolved Hide resolved
libsignal-service/src/websocket/sender.rs Outdated Show resolved Hide resolved
@gferon gferon requested a review from rubdos February 8, 2023 12:54
rubdos
rubdos approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@rubdos rubdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still have a Debug impl, so that should cut all the other cases where you want to "display" the ServiceAddress.

@gferon gferon merged commit 9902841 into master Feb 8, 2023
gferon added a commit that referenced this pull request Feb 8, 2023
@gferon
Remove E164 phone numbers from ServiceAddress (#198)
10b23d5
@gferon gferon mentioned this pull request Mar 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubdos rubdos rubdos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove e164 / phone number from ServiceAddress
2 participants
@gferon @rubdos