Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define libcdio version as environment variables in docker #498

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Define libcdio version as environment variables in docker #498

merged 1 commit into from
Aug 10, 2020

Conversation

MasterOdin
Copy link
Contributor

@MasterOdin MasterOdin commented Jul 14, 2020

This moves the version for libcdio and libcdio-paranoia to be environment variables (defined above where they're used) and then uses that variable where the version is needed. This makes it a bit easier to update the version, having only to update one line instead of 3 (x2). This was inspired looking at the commit history for the last time libcdio-paranoia version.

Signed-off-by: Matthew Peveler [email protected]

@JoeLametta JoeLametta merged commit 164b604 into whipper-team:develop Aug 10, 2020
@JoeLametta
Copy link
Collaborator

Merged, thanks!

@MasterOdin MasterOdin deleted the patch-1 branch August 10, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants