Explicitly encode path as UTF-8 in truncate_filename() #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freso
force-pushed
the
issue-315-fix-unicode-error-in-truncate_filename
branch
from
ee81242
to
777a3c8
Compare
`os.pathconf()` expects a bytes object, but the path is stored as a unicode object. Since there's no specified encoding, Python chokes when trying to convert it to a bytes object. Explicitly encoding it as UTF-8 allows Python to change it to a bytes object smoothly. Fixes whipper-team#315
Freso
force-pushed
the
issue-315-fix-unicode-error-in-truncate_filename
branch
from
777a3c8
to
0fff37c
Compare
|
Wooble in #python on Freenode said:
|
JoeLametta
approved these changes
Oct 29, 2018
|
Thanks for the pull request!
That's a great advice indeed. I'll merge this pull request as is and open a new issue about it. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.pathconf()expects a bytes object, but the path is stored as a unicode object. Since there's no specified encoding, Python chokes when trying to convert it to a bytes object. Explicitly encoding it as UTF-8 allows Python to change it to a bytes object smoothly.Fixes #315