Minor touchups #161
Merged
Minor touchups #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make MusicBrainz consistently written as "MusicBrainz" and not "musicbrainz" or "Musicbrainz". Doesn't change instances that refer to the Python module or similar.
Some of this seems to be debug code which has been left in, some of it seems to just be old code that was commented out and never put back in and probably just forgotten about. Either way, we use git for a reason, so there's no need for these code snippets to stick around. The code history can be inspected and old code retrieved that way.
I left the "THOMAS" part in for now, but this seems more like a debug message than a user facing message to me—but it was also obviously something @thomasvs left in for himself, so maybe the whole if clause has no reason to still be there and should just get removed.
|
Thanks. |
|
I prefer to not have the commits squashed. ;) Even if they're all somewhat related and should probably not cause any issues, it might still be beneficial to refer to specific commits when reviewing why a bit of code looks as it does when doing |
Done 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some small things I came across and fixed up. Decided to bundle it together in one PR. :)
Depending on how long it takes for @JoeLametta to merge this in, let's see how much I get bundled in. ;)