-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove connection to parent fork. #79
Comments
This should be OK (README and project description both mention that whipper was forked from morituri): my only worry is that this move could harm whipper's discoverability. Before proceeding let's hear what other people think about this one... |
This move will actually increase Whippers discoverability as you will be able to use Github's index to search the code, and it's google rank will increase. |
+1 to deforking, although I don't understand how this affects the google rank / GH index. (Due to lack of knowledge, not a disagreement.) |
I would leave it like this for now, but I don't care too much. Unless it really hurts the discoverability. You could ask Thomas to link to the project/fork, if you do want to 'unfork'? Maybe we should really get version 1.0 out first |
I'll ask him.
Exactly. |
I'd be careful with jumping to conclusions. There doesn't seem to be any public documentation confirming that fork status affects search rankings, which means this is just guessing. I'd argue that it doesn't really matter that whipper is displayed as a fork. In fact, it makes it easier for people to find it (via the network graph, for example), and more easily realize that whipper is the more active project ("This branch is X commits ahead of thomasvs:master"). I also remember seeing many other projects where the main development effort has moved from the "original upstream" to a fork, which has become the new "real" project (while still being displayed as a fork). The only thing I can see that is affected is GitHub's own search (which doesn't include forks by default), but I don't think GitHub drives a lot of search traffic (compared to Google, where whipper is already the first result for "whipper ripper") |
Just wanted to let you know that it seems Thomas doesn't want to link to whipper in morituri's README. @tobbez Please let's all discuss in order to reach a consensus about the best way to proceed. |
Did you actually got an answer from him? I’ve tried to reach him twice some time ago about morituri, but never got an answer. |
Yep, here it is (2016/12/03):
I then replied to his message with the following one which still didn't get any reply (2016/12/04):
|
OK, here is my own email to him on 2016/03/28:
Never received any answer. |
I don't think whipper is going to be turned back into morituri at this point. It's gotten its own life now. Also, with #109 the codebase only mentions morituri for historical purposes. I think it'd be fine to "disconnect" the repository now. |
What about @tobbez point then? |
For the record, I don't have strong opinion either way at this point. If you do the disconnect, it would be apt to change the first sentence of the README to read something like |
Let's remove the fork connection on github, but keep it in the README. I think that should be fine. |
+1 to removing the fork on github, and +1 to tobbez's suggestion to change the README to say "based on" rather than "a fork of". |
I've just contacted GitHub to ask if they can unfork whipper from morituri. |
Thanks to GitHub's staff now whipper has been unlinked from morituri. All whipper's forks (children) have been kept intact. 🎆 |
Note that the project description here in GH still says «Python CD-DA ripper preferring accuracy over speed (FORKED from morituri)». There should be an "Edit" button at https://github.com/JoeLametta/whipper/ that'll allow you to edit this. |
Good catch, thanks. I've just removed the "(FORKED from morituri)" part. |
Seeing as https://github.com/thomasvs/morituri has become abandonware and we have started using the command
whipper
instead ofrip
, I move that we ask github to defork our project from the parent and be our own root repo.The text was updated successfully, but these errors were encountered: