Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring whether to auto close the drive's tray #488

Closed
rrdaud opened this issue May 23, 2020 · 5 comments
Closed

Allow configuring whether to auto close the drive's tray #488

rrdaud opened this issue May 23, 2020 · 5 comments
Assignees
Labels
Accepted Accepted issue on our roadmap Feature New feature Status: in progress Issue/pull request which is currently being worked on
Milestone

Comments

@rrdaud
Copy link

rrdaud commented May 23, 2020

It seems there's no option to skip "eject -t" from trying to close the tray, even when the drive doesn't have any.
This outputs an error on every rip operation: "WARNING:whipper.program.utils:command 'eject -t /dev/sr0' returned with exit code '1'".

@github-actions
Copy link

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing instructions.

@JoeLametta
Copy link
Collaborator

Hi, it should be already possible to avoid running the eject command of the using the -e / --eject option like this:

whipper -e never cd rip

Please let me know if it works. 😉

@JoeLametta JoeLametta added the Support Questions that needs answering with no code changes needed or that only require a one time change label May 29, 2020
@rrdaud
Copy link
Author

rrdaud commented Jun 2, 2020

It does not work, unfortunately.

The --eject parameter regulates whether to eject the disc after the ripping is complete (which I still want to happen).

The command I'm trying to avoid is the eject -t, or trying to close the tray,** before** ripping starts.

The reason is simple: there's no tray to close, so the warning is expected, unhelpful and annoying in an otherwise flawless program.

@JoeLametta JoeLametta added Accepted Accepted issue on our roadmap Feature New feature and removed Support Questions that needs answering with no code changes needed or that only require a one time change labels Jun 6, 2020
@JoeLametta JoeLametta added this to the 1.0 milestone Jun 6, 2020
@JoeLametta
Copy link
Collaborator

Thanks for the clarification.
I agree this is a needed feature: it has been scheduled for milestone 1.0

@JoeLametta JoeLametta changed the title eject -t gives an error when drive doesn't have a tray Allow configuring whether to auto close the drive's tray Jun 6, 2020
@rrdaud
Copy link
Author

rrdaud commented Jun 6, 2020

Thank you, much appreciatted!

JoeLametta added a commit that referenced this issue Sep 17, 2020
JoeLametta added a commit that referenced this issue Sep 17, 2020
@JoeLametta JoeLametta added the Status: in progress Issue/pull request which is currently being worked on label Sep 17, 2020
@JoeLametta JoeLametta self-assigned this Sep 17, 2020
JoeLametta added a commit that referenced this issue Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Feature New feature Status: in progress Issue/pull request which is currently being worked on
Projects
None yet
Development

No branches or pull requests

2 participants