Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide option to not use disambiguation in title #440

Closed
srussel opened this issue Jan 1, 2020 · 1 comment · Fixed by #536
Closed

Provide option to not use disambiguation in title #440

srussel opened this issue Jan 1, 2020 · 1 comment · Fixed by #536
Labels
Accepted Accepted issue on our roadmap Feature New feature Priority: low Low priority
Milestone
2.0

Comments

@srussel
Copy link

srussel commented Jan 1, 2020

Currently the disc title used in the template %d and the log file name contains the disambiguation. For example this release whipper uses the title "The Best of the Art of Noise (pink cover)". I would prefer to just use "The Best of the Art of Noise" without the disambiguation as it just adds unnecessary clutter to the title. And this example is one of the shorter ones. In some cases the disambiguation can be lengthy.

Maybe there could be an option to disable this or provide a different template variable for the plain title.
@JoeLametta JoeLametta added Accepted Accepted issue on our roadmap Feature New feature Priority: low Low priority labels Jan 1, 2020
@JoeLametta JoeLametta added this to the 2.0 milestone Jan 1, 2020
@JoeLametta JoeLametta mentioned this issue Jan 14, 2020
Closed
@the-confessor
Copy link

I would like to see this too.

The title used by whipper right now is a combination of the release title, the disambiguation, the medium title, and the disc number. Ideally I would like to see each of these three available as separate templates.

For example, I was ripping this CD and it gave me the following metadata:

CDDB disc id: 34121d16
MusicBrainz disc id G3m76xuCQf58XB7VVkZX_B95Bwo-
MusicBrainz lookup URL https://musicbrainz.org/cdtoc/attach?toc=1+22+347942+150+6477+30331+39838+46238+69068+83481+92660+101810+106472+126641+140022+165499+177193+200393+219690+237146+253143+266852+279259+292952+310269&tracks=22&id=G3m76xuCQf58XB7VVkZX_B95Bwo-
Disc duration: 01:17:17.226, 22 audio tracks

Matching releases:

Artist  : Camille
Title   : ilo lympia (CD + BR) (Disc 1 of 2): le cd
Duration: 01:17:16.460
URL     : https://musicbrainz.org/release/f01fd97f-8b36-40d6-bff4-5119dd940acc
Release : f01fd97f-8b36-40d6-bff4-5119dd940acc
Type    : Live
Barcode : 5099990343698
Cat no  : 5099990343629

Ultimately what I'd like to see is more like the following, where the release/medium/disambiguation/disc values are available as separate templates.

Artist  : Camille
Title   : ilo lympia (CD + BR) (Disc 1 of 2): le cd
Release : ilo lympia
Medium  : le cd
Disambiguation: CD + BR
Disc    : 1 of 2
Duration: 01:17:16.460
URL     : https://musicbrainz.org/release/f01fd97f-8b36-40d6-bff4-5119dd940acc
Release : f01fd97f-8b36-40d6-bff4-5119dd940acc
Type    : Live
Barcode : 5099990343698
Cat no  : 5099990343629

@lonemadmax lonemadmax mentioned this issue Mar 18, 2020
Open
@JoeLametta JoeLametta mentioned this issue May 15, 2021
Merged
JoeLametta added a commit that referenced this issue May 16, 2021
@JoeLametta
Merge pull request #536 from whipper-team/misc-changes-template
b6338b2 
This pull request extends the supported template variables. Additions:

- `%B`: release barcode (already included but is now allowed)
- `%C`: release catalog number (already included but is now allowed)
- `%c`: release disambiguation comment
- `%D`: disc title without disambiguation
- `%I`: MusicBrainz Disc ID
- `%M`: total number of discs in the chosen release
- `%N`: number of current disc
- `%T`: medium title

When the relative metadata is available, whipper now adds the `TRACKTOTAL`, `DISCTOTAL` and `DISCNUMBER` metadata tags to the audio tracks.

I've also taken the inspiration from pull request #476.

Resolves #401, resolves #440, resolves #448.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Feature New feature Priority: low Low priority
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Add requested template variables whipper-team/whipper
3 participants
@JoeLametta @the-confessor @srussel