Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note in the whipper output/log if development version was used #337

Closed
Freso opened this issue Nov 23, 2018 · 0 comments
Closed

Note in the whipper output/log if development version was used #337

Freso opened this issue Nov 23, 2018 · 0 comments
Assignees
@Freso
Labels
Accepted Accepted issue on our roadmap Design Design or UX/UI related Feature New feature Needed: documentation Documentation is required Needed: patch A pull request is required Priority: low Low priority Sprintable Small enough to sprint on Stretch Optional goal for the current sprint (may not be delivered)
Milestone
1.0

Comments

@Freso
Copy link
Member

Freso commented Nov 23, 2018 •
edited
Loading

https://gist.github.com/jtl999/d1d06b5730a858e912fdfccbe3aa461f was presumably done using 8c918b6 but the whipper rip log just says Log created by: whipper 0.7.2 (internal logger) with no notion that it's actually a number of commits ahead of 0.7.2. It would be nice if this could be reflected for people using development builds. Something similar to git describe --long --tags output maybe. (The whipper-git PKGBUILD has git describe --long --tags | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g' for the version string, which produces "0.7.2.r27.g8c918b6" for 8c918b6 (git describe --long --tags gives "v0.7.2-27-g8c918b6"))
@JoeLametta JoeLametta self-assigned this Nov 29, 2018
@JoeLametta JoeLametta added this to the 1.0 milestone Nov 29, 2018
@JoeLametta JoeLametta added Priority: low Low priority Design Design or UX/UI related Feature New feature Sprintable Small enough to sprint on Needed: patch A pull request is required Needed: documentation Documentation is required Stretch Optional goal for the current sprint (may not be delivered) labels Nov 29, 2018
@JoeLametta JoeLametta added the Accepted Accepted issue on our roadmap label Feb 13, 2019
@Freso Freso mentioned this issue Feb 14, 2019
Merged
Freso added a commit that referenced this issue Feb 14, 2019
@Freso
Use git to get whipper's version
af748c5 
This essentially a copy of code from spotify2musicbrainz:
https://gitlab.com/Freso/spotify2musicbrainz/commit/59157165c4ca4e7bb1d5d8b081365029ddf55c72

Given that that code is in GPLv3 (and I'm its author :)), it should be
fine to use. It is mostly boilerplate from upstream documentation
anyway: https://pypi.org/project/setuptools-scm/

Should fix #337

Signed-off-by: Frederik “Freso” S. Olesen <[email protected]>
@Freso Freso assigned Freso and unassigned JoeLametta Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Freso Freso

Labels
Accepted Accepted issue on our roadmap Design Design or UX/UI related Feature New feature Needed: documentation Documentation is required Needed: patch A pull request is required Priority: low Low priority Sprintable Small enough to sprint on Stretch Optional goal for the current sprint (may not be delivered)
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@Freso @JoeLametta