Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test HTOA peak value against 0 (integer equality) #143

Closed
3 tasks done
JoeLametta opened this issue Mar 19, 2017 · 2 comments
Closed
3 tasks done

Test HTOA peak value against 0 (integer equality) #143

JoeLametta opened this issue Mar 19, 2017 · 2 comments
Assignees
@JoeLametta
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels
Milestone
1.0

Comments

@JoeLametta
Copy link
Collaborator

JoeLametta commented Mar 19, 2017 •
edited
Loading

Just resuming what was started in #82.

Things which must be done in order to complete this one:

  • Make SoX outputs peaks calculation as integer values on a 16 bit scale
  • Update HTOA's comparison code (equality to 0)
  • Update whipper's code paths which use the peak value to reflect the format change

This issue hasn't high priority so it's scheduled for milestone 2.0 (whatever that means).
@JoeLametta JoeLametta added this to the 2.0 milestone Mar 19, 2017
@JoeLametta JoeLametta self-assigned this Mar 19, 2017
@JoeLametta JoeLametta added the Status: in progress Issue/pull request which is currently being worked on label Aug 15, 2017
@JoeLametta JoeLametta mentioned this issue Jan 30, 2018
Merged
JoeLametta added a commit that referenced this issue Feb 1, 2018
@JoeLametta
Test HTOA peak value against 0 (integer comparison)
00bf170 
Now whipper uses the absolute value of SoX's peak level as internal peak value.

Fixes #143.
@MerlijnWajer
Copy link
Collaborator

I didn't get to reviewing this yet, guess it's no longer necessary?

@JoeLametta
Copy link
Collaborator Author

I didn't get to reviewing this yet, guess it's no longer necessary?

Yep, I wasn't sure that the proposed solution made sense (now it should).

😜

@JoeLametta JoeLametta modified the milestones: 2.0, 1.0 Nov 12, 2018
@JoeLametta JoeLametta added Bug Generic bug: can be used together with more specific labels Accepted Accepted issue on our roadmap and removed Status: in progress Issue/pull request which is currently being worked on enhancement labels Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoeLametta JoeLametta

Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@MerlijnWajer @JoeLametta