Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that whipper deals properly with CD pre-emphasis #120

Closed
Freso opened this issue Jan 29, 2017 · 1 comment
Closed

Check that whipper deals properly with CD pre-emphasis #120

Freso opened this issue Jan 29, 2017 · 1 comment
Assignees
@JoeLametta
Labels
Support Questions that needs answering with no code changes needed or that only require a one time change

Comments

@Freso
Copy link
Member

Freso commented Jan 29, 2017

I'd imagine that morituri already handled this properly and is seems to be a fairly rare occurrance, but still, "better safe than sorry".

http://wiki.hydrogenaud.io/index.php?title=Pre-emphasis
https://web.archive.org/web/20141004045917/http://blowfish.be/eac/Rip/rip12-preemph.html
@JoeLametta
Copy link
Collaborator

I haven't checked but I think current whipper versions correctly detect the pre-emphasis flag (both in TOC and the subcode) and add it to the generated cue sheet (it's also reported if ripping with the WHIPPER_DEBUG environment variable set). What still needs to be done is including that information also in the logfile.

@JoeLametta JoeLametta self-assigned this Jan 31, 2017
JoeLametta added a commit that referenced this issue Feb 5, 2017
@JoeLametta
Add pre-emphasis status reporting to whipper's logfiles
fb271f0 
Fixes #120
@JoeLametta JoeLametta mentioned this issue Feb 5, 2017
Merged
@JoeLametta JoeLametta added Support Questions that needs answering with no code changes needed or that only require a one time change and removed enhancement labels Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoeLametta JoeLametta

Labels
Support Questions that needs answering with no code changes needed or that only require a one time change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Freso @JoeLametta