Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The frame number returned by
frames = w.getnframes() / (w.getframerate()/75)
is a float ending in .0, but the code only proceeds if it is an int. Presumably older versions of python didn't see a difference between 1.0 and 1, so the incorrect test went unnoticed.In modern python versions, the elif is false and so we skip to the
else
and set the length as 00:00:00 for all tracks, leading to the "Track time calculation resulted in a negative value" error.We could turn the float into an int, but I think this is just a waste of CPU cycles as divmod happily handles the float and returns the same TOC as the py2 version.