Feat/bats docs tdd #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solution: separate cmd and flag default env vars
problem: bats tests default geth cmd should not include flags
solution: share set up env code by using bats 'load' call
whilei
commented
Jun 7, 2018
tests/bats/api_env.bash
Outdated
| #!/usr/bin/env bats | ||
|
|
||
| # Current build. | ||
| : ${GETH_CMD:=$GOPATH/bin/geth} |
whilei
commented
Jun 7, 2018
tests/bats/api_env.bash
Outdated
|
|
||
| # Current build. | ||
| : ${GETH_CMD:=$GOPATH/bin/geth} | ||
| : ${GETH_OPTS:=--datadir $BATS_TMPDIR \ |
There was a problem hiding this comment.
Much sharing, very factored.
whilei
force-pushed
the
feat/bats-docs-tdd
branch
from
2152043 to
9777aa0
Compare
whilei
commented
Jun 7, 2018
| #!/usr/bin/env bats | ||
|
|
||
| # Current build. | ||
| # NOTE: Use the given temp data dir from Bats as ephemeral data-dir. |
There was a problem hiding this comment.
Use the given temp data dir from Bats as ephemeral data-dir.
whilei
commented
Jun 7, 2018
|
|
||
| # So that we don't have to bundle hardcoded test cases and dependencies | ||
| # like this dumb key along with geth production executables. | ||
| # NOTE- |
There was a problem hiding this comment.
It also seems like someday it would be good to extract this kind of testing to it's own repo.
So that we don't have to bundle hardcoded test cases and dependencies
like this dumb key along with geth production executables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.