Skip to content

Commit

Permalink
Try to not fail on PHP 8.0 failures
Browse files Browse the repository at this point in the history
  • Loading branch information
whikloj committed Jul 6, 2021
1 parent db06076 commit ad4f1c9
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
8 changes: 7 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,15 @@ on:
jobs:
build:
runs-on: ubuntu-latest
continue-on-error: ${{ matrix.experimental }}
strategy:
fail-fast: false
matrix:
php-versions: ["7.3", "7.4", "8.0"]
php-versions: ["7.3", "7.4"]
experimental: [false]
include:
- php-versions: "8.0"
experimental: true

name: PHP ${{ matrix.php-versions }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion tests/FetchTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ public function testRemoteFailure()

$this->expectException(BagItException::class);
$this->expectExceptionMessageMatches("~^Error with download of (.*?)/example/failure : The "
. "requested URL returned error: 500$~");
. "requested URL returned error: 500~");

$bag->addFetchFile($url, 'data/myfile.txt');
}
Expand Down

0 comments on commit ad4f1c9

Please sign in to comment.