Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test for the issue that crashed when some fields were not retrieved by default #27

Merged
merged 2 commits into from
Oct 25, 2018
Merged

Unit test for the issue that crashed when some fields were not retrieved by default #27

merged 2 commits into from
Oct 25, 2018

Conversation

eyp
Copy link
Contributor

@eyp eyp commented Oct 24, 2018

No description provided.

@eyp
Check if the field exists before decryption
0d4f0cb 
Sometimes the field could be marked to not be retrieved, in that case, the decrypt function will fail because because the field is undefined.
@eyp
Unit test for the issue that crashed when some fields were not retrie…
5cbe372 
…ved by default
@coveralls
Copy link

coveralls commented Oct 24, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 97

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.5%) to 96.703%
Files with Coverage Reduction New Missed Lines %
lib/mongoose-field-encryption.js 2 96.7%
Totals Coverage Status
Change from base Build 96: 0.5%
Covered Lines: 130
Relevant Lines: 134
💛 - Coveralls

@wheresvic wheresvic merged commit efcf2e0 into wheresvic:master Oct 25, 2018
@wheresvic
Copy link
Owner

Awesome thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eyp @coveralls @wheresvic