Check if the field exists before decryption

[eyp]

Sometimes the field could be marked to not be retrieved, in that case, the decrypt function will fail because because the field is undefined.

[coveralls]

Pull Request Test Coverage Report for Build 86

• 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.5%) to 96.154%

---

Totals
Change from base Build 84:	-0.5%
Covered Lines:	130
Relevant Lines:	134

---

💛 - Coveralls

[wheresvic]

Hi @eyp

Thanks a lot for taking the time to submit this fix, I will merge and make a patch bugfix release :)

[wheresvic]

@eyp Do you think you could help me in writing a test case for this patch? I tried writing one like the following:

it("should decrypt data on find() method call when only selected encrypted fields are retrieved", () => {
    // given
    let sut = getSut();

    // when
    return sut
      .save()
      .then(() => {
        expectEncryptionValues(sut);

        return NestedFieldEncryption.findOneAndUpdate(
          {
            _id: sut._id
          },
          {
            toEncryptString: "yaddayadda",
            toEncryptObject: { nested: "snoop" }
          }
        );
      })
      .then(() => {
        return NestedFieldEncryption.find({ _id: sut._id }, "__enc_toEncryptString toEncryptString");
      })
      .then(foundArray => {
        const found = foundArray[0];
        expect(found.toEncryptString).to.equal("yaddayadda");
      });
  });

But it works without the patch as well (which would have been my expectation too). Maybe I'm missing something from your use case.

Thanks!

[eyp]

Sure, I can try to write it, or revise yours.

[wheresvic]

Yes that would be awesome, we need it to prevent this bug from popping up again :) Thanks a lot!

…

On October 24, 2018 8:35:27 AM GMT+02:00, "Eduardo Yáñez Parareda" ***@***.***> wrote: You're talking about #23 , aren't you? Sure, I can try to write it, or revise yours.

-- Victor Parmar https://smalldata.tech

[eyp]

I'm sorry, but are you talking about #23 or #26 ?
Anyway, I've written another test right now for the #26 (this one)