Fix overrideMimeType() again #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to address the comment in #157 about "get an encoding". |
annevk
force-pushed
the
annevk/overridemimetype-again
branch
from
35177d8 to
4be5ae5
Compare
domenic
requested changes
Apr 10, 2018
xhr.bs
Outdated
| <p>The <dfn id=override-mime-type>override MIME type</dfn> is initially null and can get a value if | ||
| {{overrideMimeType()}} is invoked. <dfn id=final-mime-type>Final MIME type</dfn> is the | ||
| <p>The <dfn id=override-mime-type>override MIME type</dfn> is initially null and can get a value | ||
| when {{overrideMimeType()}} is invoked. <dfn id=final-mime-type>Final MIME type</dfn> is the |
There was a problem hiding this comment.
Nit: You used "the" for override MIME type but left it out for "final MIME type" and "final charset". (I prefer including it.)
xhr.bs
Outdated
| <p><dfn id=final-charset>Final charset</dfn> is the return value of these steps: | ||
|
|
||
| <ol> | ||
| <li><p>Let <var>label<var> be null. |
xhr.bs
Outdated
| <a>override charset</a> to its value. | ||
| <li><p>If <a>override MIME type</a> is failure, then set <a>override MIME type</a> to a new | ||
| <a>MIME type</a> whose <a for="MIME type">type</a> is "<code>application</code>" and | ||
| <a for="MIME type">subtype</a> is "<code>octet-stream</code>". |
There was a problem hiding this comment.
You could probably also use the literal syntax here (even though it doesn't really exist).
| <a>MIME type portion</a>. | ||
| <!-- XXX Ignore string to byte sequence conversion issues until some point in the future --> | ||
| <li><p>Set <a>override MIME type</a> to the result of <a lt="parse a MIME type">parsing</a> | ||
| <var>mime</var>. |
There was a problem hiding this comment.
This no longer throws out all the parameters. I think that is observable using e.g. a Blob response's type.
There was a problem hiding this comment.
Yeah, that's intentional (and tested).
domenic
approved these changes
Apr 11, 2018
Reset override MIME type when open() is invoked. Actually make overriding the charset parameter work (setting override MIME type to the "MIME type portion" (now essence) as done previously would always erase it. Tests: web-platform-tests/wpt#8449.
annevk
force-pushed
the
annevk/overridemimetype-again
branch
from
6a88bef to
80dcbba
Compare
|
Only Firefox required a new bug, the other browsers hadn't aligned with previous changes yet: |
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 17, 2018
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 26, 2018
…) tests, a=testonly Automatic update from web-platform-testsAdd more XMLHttpRequest overrideMimeType() tests For whatwg/xhr#157, whatwg/xhr#174, and whatwg/mimesniff#42. -- wpt-commits: ae41496630ba35cff974877498383f1280ca07c2 wpt-pr: 8449
This was referenced Sep 27, 2018
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 2, 2019
…) tests, a=testonly Automatic update from web-platform-testsAdd more XMLHttpRequest overrideMimeType() tests For whatwg/xhr#157, whatwg/xhr#174, and whatwg/mimesniff#42. -- wpt-commits: ae41496630ba35cff974877498383f1280ca07c2 wpt-pr: 8449 UltraBlame original commit: a743786f569a9e77f8c86a2882abee702f58f981
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…) tests, a=testonly Automatic update from web-platform-testsAdd more XMLHttpRequest overrideMimeType() tests For whatwg/xhr#157, whatwg/xhr#174, and whatwg/mimesniff#42. -- wpt-commits: ae41496630ba35cff974877498383f1280ca07c2 wpt-pr: 8449 UltraBlame original commit: a743786f569a9e77f8c86a2882abee702f58f981
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…) tests, a=testonly Automatic update from web-platform-testsAdd more XMLHttpRequest overrideMimeType() tests For whatwg/xhr#157, whatwg/xhr#174, and whatwg/mimesniff#42. -- wpt-commits: ae41496630ba35cff974877498383f1280ca07c2 wpt-pr: 8449 UltraBlame original commit: a743786f569a9e77f8c86a2882abee702f58f981
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset override MIME type when open() is invoked.
Actually make overriding the charset parameter work (setting override MIME type to the "MIME type portion" (now essence) as done previously would always erase it.
Tests: web-platform-tests/wpt#8449.
Preview | Diff