Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the FAQ here #36

Merged
merged 2 commits into from
Aug 11, 2017
Merged

Move the FAQ here #36

merged 2 commits into from
Aug 11, 2017

Conversation

foolip
Copy link
Member

@foolip foolip commented Aug 9, 2017

This was produced starting from the HTML output of
https://wiki.whatwg.org/wiki/FAQ and cleaning it up to match the style
of /working-mode and /code-of-conduct. Only very minor visible changes
were made around whitespace, quotes and similar. Actual changes to the
FAQ will be made separately.

Some minimal amount of style is carried over or invented to make it not
much worse than the old FAQ.

All IDs are preserved.

@foolip
Copy link
Member Author

foolip commented Aug 9, 2017

Like with some Bikeshed conversions, I compared the textual before/after and IDs using various scripts, so I'm pretty confident I didn't mess anything up badly.

@foolip
Copy link
Member Author

foolip commented Aug 9, 2017

Pushed another change so that there are two commits now. They shouldn't be squashed when merging, use rebase.

@foolip foolip requested a review from domenic August 9, 2017 15:46
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good first step. I guess I won't review in depth given that you have tools to check the output and you aren't changing anything on the initial import. Although I would omit the HTML stuff ("HTML", "HTML syntax issues", "HTML feature proposals", "WHATWG and the W3C HTML WG", "Using HTML") even from the initial import.

I think there will be real value when we start updating this, especially given overlap with /working-mode.

I'm worried about the /faq redirect and wonder what others think there.

@@ -84,7 +84,6 @@ redirect permanent /x https://xhr.spec.whatwg.org/
redirect permanent /xhr https://xhr.spec.whatwg.org/

redirect permanent /newbug https://github.com/whatwg/html/issues/new
redirect permanent /faq https://wiki.whatwg.org/wiki/FAQ
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh. Given cached redirects, we may need a new URL...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User agents tend not to cache them long so I think we should be fine. We could go with frequently-asked-questions though if we wanted to. Would be consistent with code-of-conduct and working-mode.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping that /faq it was rarely linked, but https://html.spec.whatwg.org/ does. But, I'd still like to use the shorter URL, any breakage will be transient.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shorter URL is nice. If you all aren't worried then I guess I am not either.

@domenic
Copy link
Member

domenic commented Aug 9, 2017

Other thoughts: we may want to add self-links, like we did in working-mode. And we may want to mint new IDs, as following this wiki-generated convention for future edits is going to be painful.

foolip added a commit to whatwg/html that referenced this pull request Aug 10, 2017
From https://wiki.whatwg.org/wiki/FAQ

Initial markdown produced using the already sanitized HTML from
whatwg/whatwg.org#36 and
https://domchristie.github.io/to-markdown/ to convert it to
GitHub-flavored Markdown.
@foolip
Copy link
Member Author

foolip commented Aug 10, 2017

I'm going to remove the mailing list part of this as well, instructions for Outlook aren't that helpful. I'll leave it on the wiki when updating it to point to the new FAQs.

sideshowbarker pushed a commit to whatwg/html that referenced this pull request Aug 10, 2017
From https://wiki.whatwg.org/wiki/FAQ

Initial markdown produced using the already sanitized HTML from
whatwg/whatwg.org#36 and
https://domchristie.github.io/to-markdown/ to convert it to
GitHub-flavored Markdown.
@foolip
Copy link
Member Author

foolip commented Aug 10, 2017

This is now ready for review again, I've minted new IDs and done some more cleanup. Still no real changes to the actual content of course.

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes LGTM. Thanks especially for doing the id/self-link work. Happy to merge when you think it's ready, although we might indeed want to get a nice commit history like:

  • Move the FAQ here
  • Fix broken/redirecting/absolute links in the FAQ
  • Drop some FAQ sections
  • Improve IDs and styling of FAQ

which would involve some Git surgery. (Or maybe just two commits, one for moving and one for everything else.)

@foolip
Copy link
Member Author

foolip commented Aug 10, 2017

I enjoy Git surgery, will try to turn it into something nicer and merge tomorrow.

foolip added 2 commits August 11, 2017 14:59
This was produced starting from the HTML output of
https://wiki.whatwg.org/wiki/FAQ and cleaning it up to match the style
of /working-mode and /code-of-conduct. New IDs were minted, but no
changes to the text content was made, verified using
https://github.com/foolip/epubbase/blob/master/worddiff.py.

Some minimal amount of style is carried over or invented to make it not
much worse than the old FAQ.
* Use “quotes” and ’s (like /working-mode)
* Remove Code of Conduct question, it's linked from the top of the page
* Remove broken showModalDialog() link.
* Remove bold and italics where it seems out of place.
@foolip
Copy link
Member Author

foolip commented Aug 11, 2017

OK, I went with two commits, because once the HTML parts were out of the FAQ, the resulting second commit wasn't too big.

@foolip foolip merged commit a418543 into master Aug 11, 2017
@foolip foolip deleted the faq branch August 11, 2017 13:10
alice pushed a commit to alice/html that referenced this pull request Jan 8, 2019
From https://wiki.whatwg.org/wiki/FAQ

Initial markdown produced using the already sanitized HTML from
whatwg/whatwg.org#36 and
https://domchristie.github.io/to-markdown/ to convert it to
GitHub-flavored Markdown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants