Editorial: Completion reform for ECMAScript AOs #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also drive-by Completion -> Completion Record to match ecma262 style.
|
I can't seem to request reviewers, cc @domenic |
bakkot
reviewed
Mar 1, 2022
saschanaz
reviewed
Mar 1, 2022
| @@ -7133,7 +7133,7 @@ to its caller, and so on. | |||
| Consider the following algorithm: | |||
|
|
|||
| 1. Let |x| be the ECMAScript value passed in to this algorithm. | |||
| 1. Let |y| be the result of calling <a abstract-op>ToString</a>(|x|). | |||
| 1. Let |y| be the result of calling [=?=] <a abstract-op>ToString</a>(|x|). | |||
There was a problem hiding this comment.
TIL [=?=] is possible, I guess Streams should also use it.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
bakkot
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the tc39/ecma262#2547 ecma262 has reformed how it deals with Completion Records. See tc39/ecma262#253 (comment) for a brief description of when to use
?vs!vs nothing at all.This PR was generated in part by this script being passed
index.bsand a locally generated copy of ecma262'sbiblio.json.It is probably easier to review this PR commit-by-commit.
This is the counterpart to whatwg/html#7661.
/cc other ecma262 editors @bakkot and @michaelficarra
Preview | Diff