Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict application/x-www-form-urlencoded parser to UTF-8 #84

Closed
annevk opened this issue Feb 9, 2016 · 2 comments
Closed

Restrict application/x-www-form-urlencoded parser to UTF-8 #84

annevk opened this issue Feb 9, 2016 · 2 comments

Comments

@annevk
Copy link
Member

annevk commented Feb 9, 2016

I guess we need to introduce decode without BOM for this special use case in Encoding. The idea here is that Encoding only exposes high-level hooks to other specifications, so its internal algorithms can be reshuffled if we wanted to.
@annevk annevk mentioned this issue Dec 18, 2016
Closed
@annevk
Copy link
Member Author

annevk commented Jan 6, 2017

As I commented in whatwg/encoding, I think the solution here is to limit support to UTF-8 and leave legacy encodings up to applications, as they'll slowly disappear over time and browsers will never have to support them for this algorithm (and never should be tempted to implement such support either).

annevk added a commit that referenced this issue Jan 6, 2017
@annevk
Only support UTF-8 for the urlencoded parser
d743575 
Fixes #84.
@annevk annevk mentioned this issue Jan 6, 2017
Merged
@annevk annevk changed the title application/x-www-form-urlencoded parser should not invoke decoder directly Restrict application/x-www-form-urlencoded parser to UTF-8 Jan 11, 2017
annevk added a commit that referenced this issue Jan 17, 2017
@annevk
Parse application/x-www-form-urlencoded using UTF-8 only
3fe9696 
This changes the following things that were not implemented or caused contradictions in the URL Standard:

* No more support for non-UTF-8 encodings.
* No more support for _charset_.
* No more restricting input to ASCII bytes.
* Make it clear that decoding doesn't strip any BOM.

Tests: web-platform-tests/wpt#4517.

Fixes #84.
@annevk
Copy link
Member Author

annevk commented Jan 17, 2017

Browser issues have been filed as part of the WPT PR and are linked from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@annevk