Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix closed getter note (fixes #912) #914

Merged
merged 3 commits into from
Mar 29, 2018
Merged

Fix closed getter note (fixes #912) #914

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8287e6c
Fix closed getter note (fixes #912)
surma Mar 28, 2018
981da37
My reading comprehension is a C-.
surma Mar 28, 2018
c2863de
Also fix note on BYOB reader
surma Mar 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1300,10 +1300,12 @@ lt="ReadableStreamDefaultReader(stream)">new ReadableStreamDefaultReader(<var>st
<h5 id="default-reader-closed" attribute for="ReadableStreamDefaultReader" lt="closed">get closed</h5>

<div class="note">
The <code>closed</code> getter returns a promise that will be fulfilled when the stream becomes closed or the
reader's lock is <a lt="release a read lock">released</a>, or rejected if the stream ever errors.
The <code>closed</code> getter returns a promise that will be fulfilled when the stream becomes closed, or rejected if
the stream ever errors or the reader's lock is <a lt="release a read lock">released</a> before the stream finishes
closing or the stream errors.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or the stream errors.

I don't think you need to say this, as you've already made it clear that the promise rejects on error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

</div>


<emu-alg>
1. If ! IsReadableStreamDefaultReader(*this*) is *false*, return <a>a promise rejected with</a> a *TypeError* exception.
1. Return *this*.[[closedPromise]].
Expand Down Expand Up @@ -3531,7 +3533,7 @@ lt="WritableStreamDefaultWriter(stream)">new WritableStreamDefaultWriter(<var>st
<div class="note">
The <code>closed</code> getter returns a promise that will be fulfilled when the stream becomes closed, or rejected if
the stream ever errors or the writer's lock is <a lt="release a write lock">released</a> before the stream finishes
closing.
closing or the stream errors.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above.

</div>

<emu-alg>
Expand Down