Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Link to whatwg/meta COMMITING.md #867

Merged
merged 7 commits into from
Jan 10, 2018
Merged

Editorial: Link to whatwg/meta COMMITING.md #867

merged 7 commits into from
Jan 10, 2018

Conversation

snuggs
Copy link
Member

@snuggs snuggs commented Jan 6, 2018

Addresses:
- whatwg/meta#65

@annevk
Copy link
Member

annevk commented Jan 7, 2018

Should this also reference https://github.com/whatwg/meta/blob/master/CONTRIBUTING.md? And be renamed in uppercase for consistency?

@snuggs
Copy link
Member Author

snuggs commented Jan 7, 2018 •
edited
Loading

@annevk this should be more to our liking, yes?

Also updated to have Pull Requests section similar to https://github.com/whatwg/html/blob/master/CONTRIBUTING.md#pull-requests

@snuggs
Copy link
Member Author

snuggs commented Jan 7, 2018

Also an aside nit. Would changing a reference link be considered Meta or Editorial? Probably splitting hairs but would rather follow the "in" crowd. 😎

domenic
domenic requested changes Jan 8, 2018
View reviewed changes
CONTRIBUTING.md Outdated

These are the guidelines for contributing to the Streams Standard. First see the [WHATWG contributor guidelines](https://github.com/whatwg/meta/blob/master/CONTRIBUTING.md).

We label [good first issues](https://github.com/whatwg/html/labels/good%20first%20issue) that you could help us fix, to get a taste for how to submit pull requests, how the build process works, and so on.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be streams, not html

CONTRIBUTING.md Outdated

## Pull Requests

In short, change `source` and submit your patch. Try to follow the [spec editorial conventions](#spec-editorial-conventions) below.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source file does not exist here.

CONTRIBUTING.md Outdated

We label [good first issues](https://github.com/whatwg/html/labels/good%20first%20issue) that you could help us fix, to get a taste for how to submit pull requests, how the build process works, and so on.

## Pull Requests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lowercase "r" for consistency

@annevk annevk mentioned this pull request Jan 9, 2018
Closed
@snuggs
Copy link
Member Author

snuggs commented Jan 10, 2018

@domenic should look better to our liking. Thanks for the nits.

P.S. I signed the participation agreement. Hasn't propagated yet tho. /cc @annevk

snuggs
snuggs commented Jan 10, 2018
View reviewed changes
Copy link
Member Author

@snuggs snuggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit.

CONTRIBUTING.md
@@ -1,4 +1,18 @@
# Contribution guidelines for the Streams Standard
# Streams Standard contributor guidelines
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@domenic "Streams standard"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, in this case "Streams Standard" is a proper noun.

domenic
domenic approved these changes Jan 10, 2018
View reviewed changes
CONTRIBUTING.md
@@ -1,4 +1,18 @@
# Contribution guidelines for the Streams Standard
# Streams Standard contributor guidelines
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, in this case "Streams Standard" is a proper noun.

@domenic domenic merged commit 8f3e114 into whatwg:master Jan 10, 2018
@snuggs snuggs deleted the patch-1 branch January 11, 2018 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snuggs @annevk @domenic